Add starting state#258
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Fix some broken test infra for the new starting properties, too.
Refresh Python and Rust clients from api.tower.dev now that the starting state has shipped. Adapt tower-cmd call sites: revert RunParameterInput -> RunParameter (prod kept the original name) and pass environment: None for the new optional DescribeAppParams field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The OpenAPI spec bump to v0.10.24 made `Run.starting_at` and `RunResults.starting` required (the former is `Option::deserialize`, so the JSON key must be present even if null). The mock server wasn't emitting them, so the new generated client deserialization fell into `UnknownValue` and surfaced as 204/"wasn't able to understand" errors across the integration suite.
Regenerated CancelRunResponse now has a required cancelled_child_runs
field; mock server was returning only {"run": ...} which broke
deserialization and produced empty CLI output in integration tests.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
socksy
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the starting state to our SDK. It's a new state that we're adding to tower to differentiate "running" time from provisioning and/or general setup time. I also did a cargo fmt along the way.
The real changes are in
src/tower/_client.pyandtests/tower/test_client.py-- the rest are generated code due to the client bumps.