ToopherIframe.validate mutates the data parameter, which might be immutable

[smholloway]

In Flask, the request data is an ImmutableMultiDict, so the ToopherIframe.validate method will throw an error when trying to delete the Toopher signature.

Here's how I called validate:

validated_data = api.validate(request.args, request_token)

And this is the line that threw the error:

del data['toopher_sig']

I suggest we make a mutable copy of the data that we can manipulate and return. There's probably a cleaner way to do it, but this is how I got around it in my example:

mutable_dict = {}
for key in data.keys():
    mutable_dict[key] = data[key]

[egrim]

Nice catch, @smholloway - note that we'll need to decide whether we want a shallow copy:

mutable_dict = dict(data)

or a deepcopy:

import copy
mutable_dict = copy.deepcopy(data)

[smholloway]

See PR #30

[trdarr]

#30 addressed this issue and was merged six months ago.