STORM-2607: Switch OffsetManager to track earliest uncommitted offset…#1
Merged
Conversation
… instead of last committed offset for compatibility with commitSync consumer API
Author
|
Not sure why the comment above has duplicated text. When I open the edit window it looks fine. Oh well :) |
Owner
|
Tks @srdo ! I take a look! Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… instead of last committed offset for compatibility with commitSync consumer API
Hi @tiodollar. I thought it would be good to get some test coverage for the OffsetManager, so I've made some additions to your branch. I found some issues with the fix for STORM-2607 along the way. Hope you'll take a look at these changes and merge them into your PR apache#2181 if you think they make sense.