[close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774)#775
Merged
shiyuhang0 merged 5 commits intotikv:masterfrom Jun 4, 2024
Merged
[close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774)#775shiyuhang0 merged 5 commits intotikv:masterfrom
shiyuhang0 merged 5 commits intotikv:masterfrom
Conversation
shiyuhang0
reviewed
Jun 3, 2024
| createExecutorService(WRITE_BUFFER_SIZE)); | ||
| } | ||
|
|
||
| public TwoPhaseCommitter( |
Collaborator
Collaborator
|
Please fix DCO by
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
============================================
- Coverage 34.81% 34.65% -0.16%
+ Complexity 1355 1345 -10
============================================
Files 266 266
Lines 14283 14285 +2
Branches 1606 1606
============================================
- Hits 4972 4950 -22
- Misses 8875 8891 +16
- Partials 436 444 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: b.tian <b.tian@trip.com>
shiyuhang0
approved these changes
Jun 4, 2024
Collaborator
|
Tests have passed, they failed in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this PR solve?
Issue Number: close #issue_number
Problem Description: TBD
What is changed and how does it work?
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes