Skip to content

Make grid_space_filling() work with qual params again#448

Merged
hfrick merged 1 commit intomainfrom
grid-qual-param
Apr 9, 2026
Merged

Make grid_space_filling() work with qual params again#448
hfrick merged 1 commit intomainfrom
grid-qual-param

Conversation

@hfrick
Copy link
Copy Markdown
Member

@hfrick hfrick commented Apr 9, 2026

Closes #447

The new stricter input checks to range_get() mean it only worked for quant parameters - however, we are not using the ranges anywhere, so I've removed the line.

library(dials)
#> Loading required package: scales

pset <- parameters(surv_dist())
grid_space_filling(pset, size = 10)
#> # A tibble: 6 × 1
#>   surv_dist  
#>   <chr>      
#> 1 logistic   
#> 2 weibull    
#> 3 loglogistic
#> 4 exponential
#> 5 gaussian   
#> 6 lognormal

Created on 2026-04-09 with reprex v2.1.1

which indirectly makes this work only for quant parameters with the new stricter input checks to `range_get()`
@hfrick hfrick merged commit f8990cc into main Apr 9, 2026
15 checks passed
@hfrick hfrick deleted the grid-qual-param branch April 9, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grid_space_filling() fails with qual parameter

1 participant