Conversation
|
c2cb548 to
fb87c6c
Compare
|
Watch app and complications are now also showing Loop completion freshness using color. BG going stale is still denoted with dashes. |
fd0554b to
cf77081
Compare
nhamming
left a comment
There was a problem hiding this comment.
A question about why there seems to be 2 different definitions of stale. Probably me missing something.
|
|
||
| glucoseLabel.setHidden(true) | ||
| glucoseLabel.setText("---") | ||
| glucoseLabel.setHidden(false) |
There was a problem hiding this comment.
Given this line, Line 62 isn't needed.
darinkrauss
left a comment
There was a problem hiding this comment.
LGTM. More only questions were around the use of LoopCompletionFreshness versus RecencyInterval, but @nhamming covered that. 🚀
|
Re-requested reviews, just to make sure my responses address your comments before merging. |
darinkrauss
left a comment
There was a problem hiding this comment.
LGTM! 🚀
If RecencyInterval is specific to glucose values, then perhaps renaming this to something more specific might clarify the difference.
|
@darinkrauss It's not just for glucose data. It's also for pump data. It's about the age limit of data Loop is willing to use for creating a forecast. Maybe |
|
@ps2 Yes, something to distinguish it from the loop completion freshness. But, you can also do this in a later code change. |
Update based on design review of DIY merge. https://tidepool.atlassian.net/browse/LOOP-927