Revert: restore GoogleCredential.FromJson (fix Google OAuth) - #87
Merged
Conversation
…th CredentialFactory" This reverts commit 87f438f.
thomasluizon
added a commit
that referenced
this pull request
Jun 5, 2026
…ve ordering (#185) Bundles four correlated chat-agent changes: - #83: tag chat tools (list/create/update/delete_tag) delegating to existing MediatR handlers, registered in DI and catalogued under tags.read/write/delete. - #89: ReorderGoalsTool (mirrors ReorderHabitsTool) + unit tests for the new/write tag and goal tools; reorder_goals added to GoalsWrite.chatTools. - #88: full executor routing — every mutating MCP method (GoalTools, TagTools, ProfileTools, NotificationTools, UserFactTools, SubscriptionTools) now routes through McpExecutorBridge → IAgentOperationExecutor for shared policy + audit, mapping mismatched methods to their consolidated chat ops. Hard cases routed too: assign_tags via a new tag_ids id-path on AssignTagsTool (id-based, replace-all, no auto-create; MCP id contract unchanged) and get_referral_code via a new GetReferralCodeTool + ReferralsWrite capability + WriteReferrals scope (added to ClaudeDefaultScopes). Destructive routed deletes (goal/tag/notification/user-fact) accept and forward a confirmation token. No mutating MCP method remains on direct MediatR. update_goal_progress widened to accept goal_id so its MCP method can route. - #87: tool ordering is now data — int Order default-interface member on IAiTool (create_habit=0, create_sub_habit=1, assign_tags=2, default int.MaxValue); the hardcoded switch in ProcessUserChatCommand is replaced by the registry lookup. Adds Chat/Tools/README.md documenting the contract, Order, catalog invariant, and MCP-routing relationship. Existing MCP toolset unit tests migrated to the executor-routed pattern. Refs thomasluizon/orbit-ui-mobile#83, thomasluizon/orbit-ui-mobile#89, thomasluizon/orbit-ui-mobile#88, thomasluizon/orbit-ui-mobile#87 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
87f438fwhich replacedGoogleCredential.FromJson/FromFilewithCredentialFactoryAPICredentialFactoryAPI was breaking Firebase credential initialization, causing Google OAuth to failGoogleCredential.FromJson()/GoogleCredential.FromFile()callsTest plan
🤖 Generated with Claude Code