Skip to content

chore(ci): exclude email templates and load-tests from SonarCloud #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasluizon merged 2 commits into from
Jul 13, 2026
Merged

chore(ci): exclude email templates and load-tests from SonarCloud #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1133af2
chore(ci): exclude email templates and load-tests from SonarCloud
thomasluizon Jul 13, 2026
7ec2e7f
Merge branch 'main' into chore/api-sonar-exclude-generated
thomasluizon Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ jobs:
# DROPPED (now in coverage): Services/AppConfigService.cs (pure ConvertValue<T> + injectable cache/repo) and
# Services/UserDateService.cs (user-timezone "today" + week-start, injectable deps) — both live in
# Orbit.Infrastructure, which is in the coverage run, so they are unit-testable and should count.
# sonar.exclusions additions — non-product / false-positive sources:
# Email/Templates/** HTML-email templates. Web:S1827/S6819/S5257 (drop cellspacing, use <img> not role=presentation, replace layout tables with CSS) are false positives for email: table layout + cellspacing/cellpadding + role="presentation" are the required cross-client techniques (Outlook/legacy clients lack CSS layout support). Static assets with no maintainability value.
# load-tests/** k6 load-test scenario scripts — developer tooling, not shipped product code (parity with **/.claude/**).
- name: SonarScanner Begin
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand All @@ -77,7 +80,7 @@ jobs:
/o:"thomasluizon" \
/d:sonar.token="${SONAR_TOKEN}" \
/d:sonar.cs.opencover.reportsPaths="**/coverage.opencover.xml" \
/d:sonar.exclusions="**/Migrations/**,**/bin/**,**/obj/**,**/OAuth/OAuthLoginPage.cs,**/.claude/**" \
/d:sonar.exclusions="**/Migrations/**,**/bin/**,**/obj/**,**/OAuth/OAuthLoginPage.cs,**/.claude/**,**/Email/Templates/**,**/load-tests/**" \
/d:sonar.coverage.exclusions="**/Program.cs,**/Extensions/ServiceCollectionExtensions*.cs,**/Extensions/WebApplicationExtensions.cs,**/Middleware/**,**/OpenApi/**,**/OAuth/**,**/Persistence/OrbitDbContext.cs,**/Persistence/OrbitDbContextFactory.cs,**/Persistence/GenericRepository.cs,**/Persistence/UnitOfWork.cs,**/Persistence/AccountResetRepository.cs,**/Configuration/**,**/Services/ReminderSchedulerService.cs,**/Services/SlipAlertSchedulerService.cs,**/Services/GoalDeadlineNotificationService.cs,**/Services/HabitDueDateAdvancementService.cs,**/Services/DataEncryptionMigrationService.cs,**/Services/PushNotificationService.cs,**/Services/AccountDeletionService.cs,**/Services/GoogleTokenService.cs,**/Services/BackgroundServiceHealthCheck.cs,**/Services/StripeCouponRewardService.cs,**/AI/AiCompletionClient.cs,**/Services/GeoLocationService.cs,**/Orbit.Analyzers/**"

- name: Build
Expand Down
Loading