private become protected so ease overriding#40
Conversation
|
@franckOL I will accept PR on gyssels/Arduino-CmdMessenger, and I messaging the other PR submitters so it can become an active branch |
Do you mean that I must do a PR to your fork https://github.com/gyssels/Arduino-CmdMessenger ? I have some enhancements that I can propose later. |
|
Thank you for the contribution. After review we are not taking this change for a few reasons:
If you have a specific use case that requires subclassing we are open to discussing a narrower targeted change. Thank you for the effort. |
No description provided.