Skip to content

private become protected so ease overriding#40

Closed
franckOL wants to merge 2 commits into
thijse:masterfrom
franckOL:master
Closed

private become protected so ease overriding#40
franckOL wants to merge 2 commits into
thijse:masterfrom
franckOL:master

Conversation

@franckOL

Copy link
Copy Markdown

No description provided.

@gyssels

gyssels commented Sep 30, 2021

Copy link
Copy Markdown

@franckOL I will accept PR on gyssels/Arduino-CmdMessenger, and I messaging the other PR submitters so it can become an active branch
I engage myself to do a full PR back here if in the future I'll not maintain this anymore.

@franckOL

Copy link
Copy Markdown
Author

@franckOL I will accept PR on gyssels/Arduino-CmdMessenger, and I messaging the other PR submitters so it can become an active branch I engage myself to do a full PR back here if in the future I'll not maintain this anymore.

Do you mean that I must do a PR to your fork https://github.com/gyssels/Arduino-CmdMessenger ?

I have some enhancements that I can propose later.

@thijse

thijse commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Thank you for the contribution. After review we are not taking this change for a few reasons:

  1. Changing the access specifier from private to protected is a design decision we want to keep — the internal state (buffers, parsing cursor, callback list) is intentionally not part of the public API contract.
  2. The Mbed platform abstraction (conditional typedefs for Stream and byte) adds significant complexity and conditional compilation paths that are hard to test and maintain.
  3. The byte/Stream typedef changes are a breaking API change that would affect all existing user code.

If you have a specific use case that requires subclassing we are open to discussing a narrower targeted change. Thank you for the effort.

@thijse thijse closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants