Skip to content

Use updated Adafruit MAX31855 library#33

Closed
ivankravets wants to merge 1 commit into
thijse:masterfrom
ivankravets:patch-4
Closed

Use updated Adafruit MAX31855 library#33
ivankravets wants to merge 1 commit into
thijse:masterfrom
ivankravets:patch-4

Conversation

@ivankravets

Copy link
Copy Markdown
Contributor

No description provided.

@stejsoftware

Copy link
Copy Markdown

Or can we just remove the dependency completely? its only used by the examples.

@ivankravets

Copy link
Copy Markdown
Contributor Author

Sure, if your library does not depend on other libraries, no need to specify them here.

@gyssels

gyssels commented Sep 30, 2021

Copy link
Copy Markdown

@ivankravets I will accept PR on gyssels/Arduino-CmdMessenger, and I messaging the other PR submitters so it can become an active branch
I engage myself to do a full PR back here if in the future I'll not maintain this anymore.

thijse added a commit that referenced this pull request Jun 1, 2026
Applied PRs:
- #33: Fix Adafruit library name in library.json
- #35: Add #if guards for CMDMESSENGER_MAXCALLBACKS, LastArgLength tracking
- #36: Fix startCommand init, Serial.print->comms->print, return NULL fix
- #37: Add unescape() calls in readStringArg/copyStringArg/compareStringArg
- #42: Fix min/max types for ESP8266 (ConsoleShell, HeaterSim)
- #44: Reformat LICENSE.md for GitHub detection

New features (from MobiFlight fork):
- sendArg(T) - send argument without field separator
- sendArg(T, n) - send with precision, no separator
- sendSciArg(double, n) - scientific notation, no separator
- sendBinArg(T) - binary format, no separator
- New example: SendWithoutSeparator

Other:
- Add VS Code tasks.json and launch.json
- Add .gitignore
- Add new keywords to keywords.txt
@thijse

thijse commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Thank you for the fix. The Adafruit MAX31855 library has been removed from library.json dependencies entirely (commit 48c03a9) — it is only used in the TemperatureControl example and was never a core library dependency, so its presence in the dependency list was causing PlatformIO install failures for all users. The underlying issue you identified (wrong library name) is now moot. Closing.

@thijse thijse closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants