tests: Add some initial tests for tuf.repository#2651
Merged
jku merged 1 commit intotheupdateframework:developfrom Jun 3, 2024
Merged
tests: Add some initial tests for tuf.repository#2651jku merged 1 commit intotheupdateframework:developfrom
jku merged 1 commit intotheupdateframework:developfrom
Conversation
Merged
This comment was marked as outdated.
This comment was marked as outdated.
Pull Request Test Coverage Report for Build 9345843931Details
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
These are pretty basic and do not test much about the content of the repository... but it does check version numbers (and how many versions have been published) in a couple of situations. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
lukpueh
approved these changes
Jun 3, 2024
Member
lukpueh
left a comment
lukpueh
left a comment
There was a problem hiding this comment.
Looks great! I think the tests are reasonable and okay easy to understand. The repository is harder and maybe not so intuitive to implement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard to tell how easy these are to understand for someone who did not write the module... but here's my attempt at testing the
tuf.repository.Repositoryinterface:expectedFailurebecause of repository: Tweak snapshot/timestamp triggers #2438