rimage: Add function to read section content with allocation#2649
Closed
ktrzcinx wants to merge 3 commits intothesofproject:masterfrom
Closed
rimage: Add function to read section content with allocation#2649ktrzcinx wants to merge 3 commits intothesofproject:masterfrom
ktrzcinx wants to merge 3 commits intothesofproject:masterfrom
Conversation
Code formatting should be consistent and function arguments should be aligned to opening parenthesis. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Unused arguments shouldn't be passed to function because it makes code messy. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
In many functions there is need to read user section content and check firmware version or write section content to some manifest or dictionary. Previously to do it, in each function was loop to search for proper section in proper module, then allocate buffer, read content and check for possible error between each step what is quite overwhelming. After change there will be one function responsible for this task. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
force-pushed
the
rimage-refactor
branch
from
0173733 to
4a4b8ef
Compare
|
@lgirdwood @dcpleung Should this one wait for #2086 and target the new source tree? |
Member
Member
Author
|
Done in #2649 and thesofproject/rimage#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many functions there is need to read user section content
and check firmware version or write section content to some
manifest or dictionary. Previously to do it, in each function
was loop to search for proper section in proper module,
then allocate buffer, read content and check for possible error
between each step what is quite overwhelming. After change there
will be one function responsible for this task.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com