[skip ci] .github: apt-get -y update#630
Conversation
marc-hb
force-pushed
the
github-remove-apt-hack
branch
from
6834fe1 to
0b71c32
Compare
marc-hb
changed the title
Because it can save time. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Because Ubuntu VMs on github have a package index that is out of date by design: https://github.com/actions/virtual-environments/issues/ 1757 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
github-remove-apt-hack
branch
from
0b71c32 to
1a66225
Compare
| run: sudo apt-get -y update | ||
|
|
||
| - name: get python libs | ||
| # FIXME: apt-get succeeds but 'import numpy' still fails!? |
There was a problem hiding this comment.
We still have failure with "import numpy" after installing python3-numpy?
I installed with pip3 but it should be the same, right?
There was a problem hiding this comment.
What happened here is pylint complaining that it cannot find python3-numpy. Maybe it was specific to pylint and maybe it was specific to github and maybe it's not happening anymore. Anyway it's off-topic in this PR :-)
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: yamllint ourselves | ||
| run: yamllint .github/workflows/pull_request.yml |
There was a problem hiding this comment.
Sorry for being silly bit is this calling itself?
There was a problem hiding this comment.
Yes this file checks itself. This will obviously not work if it's totally broken but even in that most extreme case it's still a good hint to run this locally.
fredoh9
left a comment
fredoh9
left a comment
There was a problem hiding this comment.
looks good, thank you for removing HACK
2 participants
Because Ubuntu VMs on github have a package index that is out of date by
design:
https://github.com/actions/virtual-environments/issues/ 1757
Signed-off-by: Marc Herbert marc.herbert@intel.com