ASoC: SOF: ipc4-pcm: Continue the pipeline trigger in case of IPC tim…#5700
Open
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: SOF: ipc4-pcm: Continue the pipeline trigger in case of IPC tim…#5700ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
…eout Ignore IPC errors for pipeline state change if the firmware state is crashed or the IPC has timed out. If the firmware has crashed the kernel still needs to go through the state changes to reset it's internal to be able to correctly work the next time the DSP is booted up. The case with IPC timeout is a bit more problematic, but it has been rootcaused to be the result of system scheduling blockage and the firmware did actually received and handled the message, but the reply handling got blocked by issues outside of the SOF stack. So far the best way to handle this is to continue with setting the state. Fixes: c40aad7 ("ASoC: SOF: ipc4-pcm: Workaround for crashed firmware on system suspend") Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
bardliao
reviewed
Mar 18, 2026
bardliao
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eout
Ignore IPC errors for pipeline state change if the firmware state is crashed or the IPC has timed out.
If the firmware has crashed the kernel still needs to go through the state changes to reset it's internal to be able to correctly work the next time the DSP is booted up.
The case with IPC timeout is a bit more problematic, but it has been rootcaused to be the result of system scheduling blockage and the firmware did actually received and handled the message, but the reply handling got blocked by issues outside of the SOF stack.
So far the best way to handle this is to continue with setting the state.
Fixes: c40aad7 ("ASoC: SOF: ipc4-pcm: Workaround for crashed firmware on system suspend")