ASoC: SOF: amd: Fix for handling spurious interrupts from DSP#4147
Merged
ranj063 merged 1 commit intothesofproject:topic/sof-devfrom Feb 2, 2023
Merged
ASoC: SOF: amd: Fix for handling spurious interrupts from DSP#4147ranj063 merged 1 commit intothesofproject:topic/sof-devfrom
ranj063 merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
reddysujith
requested review from
ajitkupandey,
bhiregoudar and
sunilkumardommati
as code owners
plbossart
requested changes
Jan 23, 2023
reddysujith
force-pushed
the
topic/sof-dev
branch
2 times, most recently
from
fa9567e to
ad09de9
Compare
ranj063
reviewed
Jan 25, 2023
plbossart
requested changes
Jan 25, 2023
reddysujith
force-pushed
the
topic/sof-dev
branch
from
ad09de9 to
145e3bd
Compare
plbossart
approved these changes
Jan 26, 2023
ranj063
approved these changes
Jan 26, 2023
bhiregoudar
approved these changes
Jan 26, 2023
sunilkumardommati
approved these changes
Jan 26, 2023
As interrupts are Level-triggered,unless and until we deassert the register the interrupts are generated which causes spurious interrupts unhandled. Now we deasserted the interrupt at top half which solved the below "nobody cared" warning. warning reported in dmesg: irq 80: nobody cared (try booting with the "irqpoll" option) CPU: 5 PID: 2735 Comm: irq/80-AudioDSP Not tainted 5.15.86-15817-g4c19f3e06d49 thesofproject#1 1bd3fd932cf58caacc95b0504d6ea1e3eab22289 Hardware name: Google Skyrim/Skyrim, BIOS Google_Skyrim.15303.0.0 01/03/2023 Call Trace: <IRQ> dump_stack_lvl+0x69/0x97 __report_bad_irq+0x3a/0xae note_interrupt+0x1a9/0x1e3 handle_irq_event_percpu+0x4b/0x6e handle_irq_event+0x36/0x5b handle_fasteoi_irq+0xae/0x171 __common_interrupt+0x48/0xc4 </IRQ> handlers: acp_irq_handler [snd_sof_amd_acp] threaded [<000000007e089f34>] acp_irq_thread [snd_sof_amd_acp] Disabling IRQ thesofproject#80 Signed-off-by: V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>
Author
|
Hi, @plbossart @ranj063 Can you please help to merge the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As interrupts are Level-triggered,until unless we deassert the register the interrupts are generated which causes spurious interrupts unhandled.
Now we deasserted the interrupt at top half which solved the below warning nobody cared.
warning reported in dmesg:
irq 80: nobody cared (try booting with the "irqpoll" option)
CPU: 5 PID: 2735 Comm: irq/80-AudioDSP
Not tainted 5.15.86-15817-g4c19f3e06d49 #1 1bd3fd932cf58caacc95b0504d6ea1e3eab22289
Hardware name: Google Skyrim/Skyrim, BIOS Google_Skyrim.15303.0.0 01/03/2023
Call Trace:
dump_stack_lvl+0x69/0x97
__report_bad_irq+0x3a/0xae
note_interrupt+0x1a9/0x1e3
handle_irq_event_percpu+0x4b/0x6e
handle_irq_event+0x36/0x5b
handle_fasteoi_irq+0xae/0x171
__common_interrupt+0x48/0xc4
Signed-off-by: V sujith kumar Reddy Vsujithkumar.Reddy@amd.com