Revert "ACPI: scan: Do not add device IDs from _CID if _HID is not va…#3525
Merged
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom Mar 18, 2022
Merged
Conversation
…lid" This reverts commit e38f9ff. Suspend-resume regressions were noticed on Intel TGLU_RVP and CML Helios Chromebook. Excert from discussion with ACPI maintainer in from thesofproject#3521 (comment): Commit e38f9ff ("ACPI: scan: Do not add device IDs from _CID if _HID is not valid") is going to be reverted, because it caused multiple systems to misbehave as per the below. BugLink: thesofproject#3459 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
ranj063,
ujfalusi and
yaochunhung
as code owners
Member
Author
|
Revert to unblock CI and make sure other bugs are not masked by this single-commit regression |
marc-hb
approved these changes
Mar 18, 2022
ranj063
approved these changes
Mar 18, 2022
ujfalusi
approved these changes
Mar 18, 2022
Collaborator
ujfalusi
left a comment
ujfalusi
left a comment
There was a problem hiding this comment.
fwiw, the revert is heading to final 5.17:
https://lore.kernel.org/lkml/CAJZ5v0gcZb9mq4WfHuGC-3zMx215u_cYMzwTkx1jxgZmu_EUbw@mail.gmail.com/
Collaborator
|
There is a single out of blue failure on ADLP_RVP_NOCODEC: Let's re-run CI to see if it is persistent. |
Collaborator
|
SOFCI TEST |
Collaborator
|
CI got stuck, but the error was gone on the completed tests. |
This was referenced Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lid"
This reverts commit e38f9ff.
Suspend-resume regressions were noticed on Intel TGLU_RVP and CML
Helios Chromebook.
Excert from discussion with ACPI maintainer in from
#3521 (comment):
Commit e38f9ff ("ACPI: scan: Do not add device IDs from _CID if _HID
is not valid") is going to be reverted, because it caused multiple
systems to misbehave as per the below.
BugLink: #3459
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com