[BUG][CML] "ASoC: Neither/both codec name/of_node are set for SSP1-Codec" shows when boot up system

[YvonneYang2]

Describe the bug
"ASoC: Neither/both codec name/of_node are set for SSP1-Codec" shows when boot up system with latest topic/sof-dev

Tested it with kernel topic/sof-dev commit: 0d22f66, issue cannot be reproduced. Will do bisect later.

To Reproduce
1.Boot up .
2.Check dmesg.

Reproduce rate
4/5

Expected result
System boot up successfully

Actual result
aplay -l shows no sound card and "ASoC: Neither/both codec name/of_node are set for SSP1-Codec" shows in boot up dmesg.

dmesg

[    1.747530] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link iDisp2
[    1.747532] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link iDisp3
[    1.747535] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link SSP1-Codec
[    1.747680] cml_rt1011_rt5682 cml_rt1011_rt5682: ASoC: Neither/both codec name/of_node are set for SSP1-Codec
[    1.747820] cml_rt1011_rt5682: probe of cml_rt1011_rt5682 failed with error -22
[    1.790841] usb 1-2.2: new low-speed USB device number 6 using xhci_hcd
[    1.896128] usb 1-2.2: New USB device found, idVendor=0000, idProduct=0538, bcdDevice= 1.00
[    1.896133] usb 1-2.2: New USB device strings: Mfr=0, Product=1, SerialNumber=0
[    1.896136] usb 1-2.2: Product:  USB OPTICAL MOUSE
[    1.902059] input:  USB OPTICAL MOUSE as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2.2/1-2.2:1.0/0003:0000:0538.0002/input/input10
[    1.902209] hid-generic 0003:0000:0538.0002: input,hidraw1: USB HID v1.11 Mouse [ USB OPTICAL MOUSE] on usb-0000:00:14.0-2.2/input0
[    1.990624] usb 1-2.4: new low-speed USB device number 7 using xhci_hcd
[    2.045623] random: crng init done
[    2.097964] usb 1-2.4: New USB device found, idVendor=046d, idProduct=c31c, bcdDevice=64.00
[    2.097966] usb 1-2.4: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[    2.097967] usb 1-2.4: Product: USB Keyboard

Test recipe
Kernel:https://github.com/thesofproject/linux/commits/topic/sof-dev commit: 16d98cd
FW: https://github.com/thesofproject/sof/tree/tgl-006-drop-stable commit: a21cba16
Tplg: same as FW, sof-cml-rt1011-rt5682.tplg
Platform: CML chrome book with i2s rt5682

dmesg.log
logger.log

[keyonjie]

Can you help add below change to print out the codec->name for debugging when the issue happen?

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index e1b65059c0c4..dbd8ed35035c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -846,8 +846,8 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card,
                 * not both or neither.
                 */
                if (!!codec->name == !!codec->of_node) {
-                       dev_err(card->dev, "ASoC: Neither/both codec name/of_node are set for %s\n",
-                               link->name);
+                       dev_err(card->dev, "ASoC: Neither/both codec name/of_node are set for %s, codec->name:%s\n",
+                               link->name, codec->name);
                        return -EINVAL;
                }

[YvonneYang2]

Dmesg shows as below after patch applied.

[    1.897455] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link iDisp1
[    1.897456] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link iDisp2
[    1.897457] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link iDisp3
[    1.897459] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link SSP1-Codec
[    1.897548] cml_rt1011_rt5682 cml_rt1011_rt5682: ASoC: Neither/both codec name/of_node are set for SSP1-Codec, codec->name:(null)
[    1.897653] cml_rt1011_rt5682: probe of cml_rt1011_rt5682 failed with error -22
[    2.245309] asix 1-2.1:1.0 eth0: register 'asix' at usb-0000:00:14.0-2.1, ASIX AX88772 USB 2.0 Ethernet, 00:0e:c6:53:56:a2
[    2.245333] usbcore: registered new interface driver asix
[    2.251899] asix 1-2.1:1.0 enx000ec65356a2: renamed from eth0
[    2.381509] random: crng init done
[    2.427875] Console: switching to colour frame buffer device 240x67

dmesg.log

[keyonjie]

Thanks @YvonneYang2.

The codec-name here is NULL, we need add more debug logs to print out the full information of the SSP1-Codec dailink.

In case you have time, can you help to try with:

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index e1b65059c0c4..8c6b8ab7b4b0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -845,6 +845,8 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card,
                 * Codec must be specified by 1 of name or OF node,
                 * not both or neither.
                 */
+               dev_info(card->dev, "dailink %s: codec[%d] name:%s, dai_name:%s\n",
+                       link->name, i, codec->dai_name);
                if (!!codec->name == !!codec->of_node) {
                        dev_err(card->dev, "ASoC: Neither/both codec name/of_node are set for %s\n",
                                link->name);

[YvonneYang2]

@keyonjie I tried to test it with your patch, but it cannot enter ubuntu and hang in the black screen after choose the kernel. Then i do the bisect, the result shows the commit f6c8ab5 cause the issue. Could please have a look?

[plbossart]

@keyonjie I tried to test it with your patch, but it cannot enter ubuntu and hang in the black screen after choose the kernel. Then i do the bisect, the result shows the commit f6c8ab5 cause the issue. Could please have a look?

@YvonneYang2 use a blacklist and manual modprobe snd-sof-pci to avoid boot issues.

[keyonjie]

@keyonjie I tried to test it with your patch, but it cannot enter ubuntu and hang in the black screen after choose the kernel. Then i do the bisect, the result shows the commit f6c8ab5 cause the issue. Could please have a look?

My bad, I missed an item with copy/paste:

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index e1b65059c0c4..dd3edc359747 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -845,6 +845,8 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card,
                 * Codec must be specified by 1 of name or OF node,
                 * not both or neither.
                 */
+               dev_info(card->dev, "dailink %s: codec[%d] name:%s, dai_name:%s\n",
+                       link->name, i, codec->name, codec->dai_name);
                if (!!codec->name == !!codec->of_node) {
                        dev_err(card->dev, "ASoC: Neither/both codec name/of_node are set for %s\n",
                                link->name);

[YvonneYang2]

Here is the boot up log after applied the patch.

[    1.818931] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link iDisp3
[    1.818933] cml_rt1011_rt5682 cml_rt1011_rt5682: info: override BE DAI link SSP1-Codec
[    1.818940] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink SSP0-Codec: codec[0] name:i2c-10EC5682:00, dai_name:rt5682-aif1
[    1.818974] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink dmic01: codec[0] name:dmic-codec, dai_name:dmic-hifi
[    1.818994] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink dmic16k: codec[0] name:dmic-codec, dai_name:dmic-hifi
[    1.819010] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink iDisp1: codec[0] name:ehdaudio0D2, dai_name:intel-hdmi-hifi1
[    1.819026] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink iDisp2: codec[0] name:ehdaudio0D2, dai_name:intel-hdmi-hifi2
[    1.819043] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink iDisp3: codec[0] name:ehdaudio0D2, dai_name:intel-hdmi-hifi3
[    1.819066] cml_rt1011_rt5682 cml_rt1011_rt5682: dailink SSP1-Codec: codec[0] name:(null), dai_name:��\x83�	
[    1.819068] cml_rt1011_rt5682 cml_rt1011_rt5682: ASoC: Neither/both codec name/of_node are set for SSP1-Codec
[    1.819194] cml_rt1011_rt5682: probe of cml_rt1011_rt5682 failed with error -22

dmesg.log

[ranj063]

@YvonneYang2 could you please try if this change helps?

diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
index 68eff29daf8f..f6837b6e1210 100644
--- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
+++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
@@ -584,8 +584,9 @@ static int snd_cml_rt1011_probe(struct platform_device *pdev)
                snd_soc_card_cml.num_configs = SPK_CH;
 
                for (i = 0; i < ARRAY_SIZE(cml_rt1011_rt5682_dailink); i++) {
-                       if (!strcmp(cml_rt1011_rt5682_dailink[i].codecs->dai_name,
-                                       CML_RT1011_CODEC_DAI)) {
+                       if (cml_rt1011_rt5682_dailink[i].num_codecs &&
+                           !strcmp(cml_rt1011_rt5682_dailink[i].codecs[0]->dai_name,
+                                   CML_RT1011_CODEC_DAI)) {
                                cml_rt1011_rt5682_dailink[i].codecs = rt1011_dais_components;
                                cml_rt1011_rt5682_dailink[i].num_codecs = SPK_CH;
                        }

[ranj063]

hmm looking more into the dmesg there's something really fishy :
[ 1.713561] cml_rt1011_rt5682 cml_rt1011_rt5682: sof_rt1011_quirk = f

This string should be printed only once when the machine driver probes. But it is printed 4 times over.

[YvonneYang2]

@YvonneYang2 could you please try if this change helps?

diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
index 68eff29daf8f..f6837b6e1210 100644
--- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
+++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
@@ -584,8 +584,9 @@ static int snd_cml_rt1011_probe(struct platform_device *pdev)
                snd_soc_card_cml.num_configs = SPK_CH;
 
                for (i = 0; i < ARRAY_SIZE(cml_rt1011_rt5682_dailink); i++) {
-                       if (!strcmp(cml_rt1011_rt5682_dailink[i].codecs->dai_name,
-                                       CML_RT1011_CODEC_DAI)) {
+                       if (cml_rt1011_rt5682_dailink[i]->num_codecs &&
+                           !strcmp(cml_rt1011_rt5682_dailink[i].codecs[0]->dai_name,
+                                   CML_RT1011_CODEC_DAI)) {
                                cml_rt1011_rt5682_dailink[i].codecs = rt1011_dais_components;
                                cml_rt1011_rt5682_dailink[i].num_codecs = SPK_CH;
                        }

Sorry, I tried to compile the kernel after this patch applied, but there were some error info during compiling.

  CC      drivers/acpi/acpica/nsrepair2.o
  HDRTEST usr/include/linux/iso_fs.h
sound/soc/intel/boards/cml_rt1011_rt5682.c: In function ‘snd_cml_rt1011_probe’:
sound/soc/intel/boards/cml_rt1011_rt5682.c:587:36: error: invalid type argument of ‘->’ (have ‘struct snd_soc_dai_link’)
    if (cml_rt1011_rt5682_dailink[i]->num_codecs &&
                                    ^~
sound/soc/intel/boards/cml_rt1011_rt5682.c:588:52: error: invalid type argument of ‘->’ (have ‘struct snd_soc_dai_link_component’)
      !strcmp(cml_rt1011_rt5682_dailink[i].codecs[0]->dai_name,
                                                    ^~
scripts/Makefile.build:266: recipe for target 'sound/soc/intel/boards/cml_rt1011_rt5682.o' failed
make[7]: *** [sound/soc/intel/boards/cml_rt1011_rt5682.o] Error 1
make[7]: *** Waiting for unfinished jobs....
   CC      drivers/acpi/acpica/nsrepair2.o
  HDRTEST usr/include/linux/iso_fs.h
sound/soc/intel/boards/cml_rt1011_rt5682.c: In function ‘snd_cml_rt1011_probe’:
sound/soc/intel/boards/cml_rt1011_rt5682.c:587:36: error: invalid type argument of ‘->’ (have ‘struct snd_soc_dai_link’)
    if (cml_rt1011_rt5682_dailink[i]->num_codecs &&
                                    ^~
sound/soc/intel/boards/cml_rt1011_rt5682.c:588:52: error: invalid type argument of ‘->’ (have ‘struct snd_soc_dai_link_component’)
      !strcmp(cml_rt1011_rt5682_dailink[i].codecs[0]->dai_name,
                                                    ^~
scripts/Makefile.build:266: recipe for target 'sound/soc/intel/boards/cml_rt1011_rt5682.o' failed
make[7]: *** [sound/soc/intel/boards/cml_rt1011_rt5682.o] Error 1
make[7]: *** Waiting for unfinished jobs....
  CC      drivers/char/agp/intel-gtt.o 

[ranj063]

Sorry, I tried to compile the kernel after this patch applied, but there were some error info during compiling.

@YvonneYang2 thanks but nevermind. I dont think that will fix the issue.

[ranj063]

it looks like a50067d could be suspicious. @YvonneYang2 please update the results of reverting this patch. @bardliao FYI

[bardliao]

@YvonneYang2 We need more log. Please add "options snd_soc_core dyndbg=+p" to /etc/modprobe.d/sof-debug.conf and get dmesg again. Thanks