Skip to content

fix: Disable shell=True in agent process launcher to prevent command injection #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joshua-Medvinsky wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Disable shell=True in agent process launcher to prevent command injection #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25eb44
fix: Disable shell=True in agent process launcher to prevent command …
Joshua-Medvinsky Jun 10, 2026
e2809f8
fix: move shlex import to module level in agent_manager
Joshua-Medvinsky Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python_a2a/agent_flow/utils/agent_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"""

import os
import shlex
import time
import json
import logging
Expand Down Expand Up @@ -194,8 +195,8 @@ def start_agent_server(

# Start the server process
process = subprocess.Popen(
command,
shell=True,
shlex.split(command) if isinstance(command, str) else command,
shell=False,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True
Expand Down