This PR adds a MissingDpendencyException to Picotainer. This exception is fired when the entry is found, but the factory method of the entry triggers a NotFoundException (because of a missing dependency fetched from the container).#4
Open
moufmouf wants to merge 2 commits intothecodingmachine:1.0from
Conversation
2 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale is to make a difference between a
getmethod that was passed a wrong ID and a messed up factory. The MissingDependencyException should not be catched while the NotFoundException is meant to be catched.