Skip to content

Hooks#32

Closed
alexkrolick wants to merge 6 commits into
masterfrom
hooks
Closed

Hooks#32
alexkrolick wants to merge 6 commits into
masterfrom
hooks

Conversation

@alexkrolick
Copy link
Copy Markdown
Collaborator

@alexkrolick alexkrolick commented Feb 13, 2019

Closes #20

alexkrolick
alexkrolick commented Feb 13, 2019
View reviewed changes
Comment thread docs/example-react-hooks.md
@@ -0,0 +1,202 @@
---
Copy link
Copy Markdown
Collaborator Author

@alexkrolick alexkrolick Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled in these examples from the rtl repo

alexkrolick
alexkrolick commented Feb 13, 2019
View reviewed changes
Comment thread website/blog/2019-02-06-react-hooks.md
@@ -0,0 +1,16 @@
---
Copy link
Copy Markdown
Collaborator Author

@alexkrolick alexkrolick Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a little FYI blog post about hooks, since they are new in the docs

alexkrolick
alexkrolick commented Feb 13, 2019
View reviewed changes
Comment thread website/siteConfig.js
colors: {
primaryColor: '#292422',
secondaryColor: '#3344bb',
secondaryColor: '#2468e5',
Copy link
Copy Markdown
Collaborator Author

@alexkrolick alexkrolick Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but the links were hard to read. This is a lighter color so they stand out from the text.

alexkrolick
alexkrolick commented Feb 13, 2019
View reviewed changes
Comment thread website/static/img/users/codecademy.svg Outdated
@@ -1,4 +1,3 @@

Copy link
Copy Markdown
Collaborator Author

@alexkrolick alexkrolick Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newline broke the svg

@kentcdodds
Copy link
Copy Markdown
Member

kentcdodds commented Feb 13, 2019

Wow! I don't have time to review this PR this week (lots going on this week), but it's fantastic you've done this. Thank you for what you're doing for the community 💯

@alexkrolick alexkrolick mentioned this pull request Feb 15, 2019
Merged
5 tasks
danielkcz
danielkcz reviewed Feb 15, 2019
View reviewed changes
Comment thread docs/react-testing-library/api.md
This was referenced Feb 16, 2019
Closed
Closed
@alexkrolick
Copy link
Copy Markdown
Collaborator Author

alexkrolick commented Mar 18, 2019 •
edited
Loading

@mpeyper feel free to take over this PR if you want to add docs here for react-hooks-testing-library (#20)

@alexkrolick alexkrolick added the 🚧 work in progress Not ready, being worked on label Mar 18, 2019
@mpeyper
Copy link
Copy Markdown
Member

mpeyper commented Mar 19, 2019 •
edited
Loading

lol, I was actually poking around to see if any more had been done towards this and I see you have tagged me in this (but spelt it wrong so I wasn't notified).

If I get time I will take a look at this, otherwise if anyone else wants to take it on, feel free to add yourself as a contributor over on `react-hooks-testing-library] repo.

@mpeyper mpeyper mentioned this pull request Mar 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds Awaiting requested review from kentcdodds

1 more reviewer

@danielkcz danielkcz danielkcz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚧 work in progress Not ready, being worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexkrolick @kentcdodds @mpeyper @danielkcz