fix: escape square brackets in ID selectors#1375
Open
mixelburg wants to merge 1 commit intotesting-library:mainfrom
Open
fix: escape square brackets in ID selectors#1375mixelburg wants to merge 1 commit intotesting-library:mainfrom
mixelburg wants to merge 1 commit intotesting-library:mainfrom
Conversation
IDs containing square brackets (e.g. ) cause to throw a SyntaxError because is interpreted as an invalid CSS attribute selector. Use CSS.escape() to properly escape IDs before interpolating them into attribute selectors. Applied in two locations: - src/queries/label-text.ts (getTagNameOfElementAssociatedWithLabelViaFor) - src/label-helpers.ts (getLabels aria-labelledby lookup) Fixes #1404
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a843f4:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an element has an ID containing square brackets (e.g.
foo[1].bar), callinggetByLabelText(or queries that resolvearia-labelledby) throws:This happens because
querySelector("[id=\"foo[1].bar\"]")interprets[1]as a CSS attribute selector, which is invalid.Fix
Use
CSS.escape()to properly escape IDs before interpolating them into attribute selectors. Applied in two locations:src/queries/label-text.ts—getTagNameOfElementAssociatedWithLabelViaForsrc/label-helpers.ts—getLabels(aria-labelledby lookup)CSS.escape()is available in all environments supported by dom-testing-library (Node >= 18).Fixes #1404