This repository was archived by the owner on Apr 23, 2021. It is now read-only.
[ROCm] Changing the return type for the device function calls from i32 to i64#171
Closed
deven-amd wants to merge 1 commit intotensorflow:masterfrom
deven-amd:deven-rocdl-device-func-i64
Closed
[ROCm] Changing the return type for the device function calls from i32 to i64#171deven-amd wants to merge 1 commit intotensorflow:masterfrom deven-amd:deven-rocdl-device-func-i64
deven-amd wants to merge 1 commit intotensorflow:masterfrom
deven-amd:deven-rocdl-device-func-i64
Conversation
…32 to i64. Also making corresponding changes in the unit test for the same
joker-eph
approved these changes
Oct 8, 2019
Contributor
|
Thanks! |
joker-eph
changed the title
Contributor
|
(nit: your title is accurately describing the "what". In general, I like to have a contextual description in the commit message to also explain the "why": https://chris.beams.io/posts/git-commit/ ; but don't bother here I've already pulled the changes in) |
tensorflow-copybara
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 9, 2019
…i64. This is matching what the runtime library is expecting. Closes #171 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#171 from deven-amd:deven-rocdl-device-func-i64 80762629a8c34e844ebdc542b34dd783990db9db PiperOrigin-RevId: 273640767
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 24, 2019
…i64. This is matching what the runtime library is expecting. Closes tensorflow/mlir#171 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#171 from deven-amd:deven-rocdl-device-func-i64 80762629a8c34e844ebdc542b34dd783990db9db PiperOrigin-RevId: 273640767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also making corresponding changes in the unit test for the same
@joker-eph @whchung