This repository was archived by the owner on Apr 23, 2021. It is now read-only.
[ROCm] Adding pass to lower GPU Dialect to ROCDL Dialect.#154
Closed
deven-amd wants to merge 1 commit intotensorflow:masterfrom
deven-amd:deven-lower-gpu-to-rocdl
Closed
[ROCm] Adding pass to lower GPU Dialect to ROCDL Dialect.#154deven-amd wants to merge 1 commit intotensorflow:masterfrom deven-amd:deven-lower-gpu-to-rocdl
deven-amd wants to merge 1 commit intotensorflow:masterfrom
deven-amd:deven-lower-gpu-to-rocdl
Conversation
River707
suggested changes
Sep 28, 2019
This is a follow-up to the PR#146 which introduced the ROCDL Dialect. This PR introduces a pass to lower GPU Dialect to the ROCDL Dialect. As with the previous PR, this one builds on the work done by @whchung, and addresses most of the review comments in the original PR.
Contributor
Author
|
Thank you for your feedback. I have pushed out a new commit which addresses the points you raised. Please re-review. thanks deven |
joker-eph
approved these changes
Oct 1, 2019
sherhut
reviewed
Oct 1, 2019
ArmageddonKnight
pushed a commit
to UofT-EcoSystem/tensorflow
that referenced
this pull request
Oct 2, 2019
This is a follow-up to the PR#146 which introduced the ROCDL Dialect. This PR introduces a pass to lower GPU Dialect to the ROCDL Dialect. As with the previous PR, this one builds on the work done by @whchung, and addresses most of the review comments in the original PR. Closes tensorflow#154 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#154 from deven-amd:deven-lower-gpu-to-rocdl 809893e08236da5ab6a38e3459692fa04247773d PiperOrigin-RevId: 272390729
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 24, 2019
This is a follow-up to the PRtensorflow/mlir#146 which introduced the ROCDL Dialect. This PR introduces a pass to lower GPU Dialect to the ROCDL Dialect. As with the previous PR, this one builds on the work done by @whchung, and addresses most of the review comments in the original PR. Closes tensorflow/mlir#154 COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#154 from deven-amd:deven-lower-gpu-to-rocdl 809893e08236da5ab6a38e3459692fa04247773d PiperOrigin-RevId: 272390729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the PR #146 which introduced the ROCDL Dialect. This PR introduces a pass to lower GPU Dialect to the ROCDL Dialect. As with the previous PR, this one builds on the work done by @whchung, and addresses most of the review comments in the original PR #63 .
@joker-eph @whchung