Fixing retries in "First Program in Python"#469
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
…e intention of the tutorial. It resulted in problems when users were trying to follow the instructions. I removed the max retries to force it to retry forever instead. This allows the tutorial to proceed as expected. However this required updating the instructions which had conflicting information about the actual retry policy.
WadeWaldron
force-pushed
the
first-program-in-python-fix
branch
from
8239003 to
1af7d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The retry policy being specified in the source code ran counter to the intention of the tutorial. It resulted in problems when users were trying to follow the instructions. I removed the max retries to force it to retry forever instead. This allows the tutorial to proceed as expected. However this required updating the instructions which had conflicting information about the actual retry policy.
Why?
While running through this tutorial I discovered that the way retries were set up ran counter to what the instructions seemed to be indicating and resulted in an application that failed rather then demonstrating the power of Temporal. Meanwhile, the instructions had conflicts claiming both that there was a maximum of 3 retries but also a maximum of 500. I've fixed these errors while adjusting the retry policy.
Checklist
I've run the application locally and updating the instructions to match.