Skip to content

keep single local node version pin in .nvmrc - #5036

Merged
jsundai merged 2 commits into
mainfrom
duplicate-node-version-files
Aug 6, 2026
Merged

keep single local node version pin in .nvmrc#5036
jsundai merged 2 commits into
mainfrom
duplicate-node-version-files

Conversation

@jsundai

@jsundai jsundai commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Remove the duplicate .node-version file so we only maintain one local Node pin.
  • Keep .nvmrc (24). This file may be more helpful to local version managers (nvm, fnm, and similar) for auto-selecting Node when working in the repo.
  • CI and Vercel are unchanged: workflows still set Node explicitly, and Vercel continues to use package.json engines.node (24.x).

Notes to reviewers

┆Attachments: EDU-6889 keep single local node version pin in .nvmrc

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview Aug 5, 2026 11:47pm

Request Review

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

This PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here.

@jsundai
jsundai marked this pull request as ready for review August 5, 2026 23:46
@jsundai
jsundai requested a review from a team as a code owner August 5, 2026 23:46
@jsundai
jsundai merged commit da275ae into main Aug 6, 2026
10 checks passed
@jsundai
jsundai deleted the duplicate-node-version-files branch August 6, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants