Create specs for $lt and $gt (among others) comparators#366
Create specs for $lt and $gt (among others) comparators#366obeliskos merged 4 commits intotechfort:masterfrom alexandernst:opsspecs
Conversation
|
@obeliskos Please note that in order to test the comparators without making funny things with the code, I exposed Also note that the specs won't pass because |
|
@obeliskos Some "crazy" tests are missing. "Crazy" as in "comparing anything with anything". |
|
@alexandernst @obeliskos if i can interject, if you compare a boolean to a string i'd throw a |
|
I'm almost sure the current code (not this specs, but the comparators) covers all possible cases of "crazy" combinations. And when I say "almost" I actually mean "I haven't found a combination that doesn't return what it should". Are we good with this PR? Remember that this mist be merge only after #365 |
|
Ok, now that #365 got merged, I'll restart travis here |
|
Whew, thanks for these tests (and fixes). |
Create specs for $lt and $gt (among others) comparators
|
No problem :) |
No description provided.