Skip to content

feat(minio): use minio's official docker image#5

Merged
Cryptophobia merged 4 commits into
teamhephy:masterfrom
duanhongyi:master
Nov 15, 2018
Merged

feat(minio): use minio's official docker image#5
Cryptophobia merged 4 commits into
teamhephy:masterfrom
duanhongyi:master

Conversation

@duanhongyi

Copy link
Copy Markdown
Member
  1. support the latest minio
  2. use minio's official docker image

@Cryptophobia

Copy link
Copy Markdown
Member

Thanks for updating the base image. Let's debate what our stance on using standard base images is a bit before we proceed with changing them everywhere.

@till till left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for sending these PRs!

Small nitpick: I would do the CI stuff in one PR and the rest in another. For the least reason to have the PR for changing the image build successfully.

I am happy with the majority doesn't care and merges this though!

Otherwise: 👍 👍 👍 👍

Comment thread Makefile
Comment thread rootfs/Dockerfile
Comment thread rootfs/Dockerfile
Comment thread .travis.yml
@till

till commented Nov 14, 2018

Copy link
Copy Markdown

@duanhongyi I have one more thing:
https://github.com/teamhephy/minio#minio-binary-mirror

Can you remove this in the README? Seems no longer applicable thanks to your work! :)

Comment thread rootfs/Dockerfile

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the verbosity of the adduser flags and @till's comments need to be addressed. Otherwise, looks really good. 💯

@duanhongyi

Copy link
Copy Markdown
Member Author

@duanhongyi I have one more thing:
https://github.com/teamhephy/minio#minio-binary-mirror

Can you remove this in the README? Seems no longer applicable thanks to your work! :)

OK

@duanhongyi

Copy link
Copy Markdown
Member Author

@duanhongyi I have one more thing:
https://github.com/teamhephy/minio#minio-binary-mirror

Can you remove this in the README? Seems no longer applicable thanks to your work! :)

ok

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryptophobia

Copy link
Copy Markdown
Member

Another awesome PR @duanhongyi! 🥇 Merging now :octocat: !

@Cryptophobia Cryptophobia merged commit 0e597d3 into teamhephy:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants