feat(minio): use minio's official docker image#5
Conversation
duanhongyi
commented
Nov 12, 2018
- support the latest minio
- use minio's official docker image
|
Thanks for updating the base image. Let's debate what our stance on using standard base images is a bit before we proceed with changing them everywhere. |
till
left a comment
There was a problem hiding this comment.
First off, thanks for sending these PRs!
Small nitpick: I would do the CI stuff in one PR and the rest in another. For the least reason to have the PR for changing the image build successfully.
I am happy with the majority doesn't care and merges this though!
Otherwise: 👍 👍 👍 👍
|
@duanhongyi I have one more thing: Can you remove this in the README? Seems no longer applicable thanks to your work! :) |
Cryptophobia
left a comment
There was a problem hiding this comment.
Just the verbosity of the adduser flags and @till's comments need to be addressed. Otherwise, looks really good. 💯
OK |
ok |
|
Another awesome PR @duanhongyi! 🥇 Merging now |