Add ask, show, and jobs story list commands#3
Merged
Merged
Conversation
Wire AskStories, ShowStories, and JobStories through the kit domain: three new OpMeta registrations and their handler functions, mirroring the existing top/new/best pattern. All seven list+single ops now live under the hackernews binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask,show, andjobscommands through the kit domain, completing all seven story-list operationstop/new/besthandlers: OpMeta registration + handler function delegating to the Client methodTest plan
go build ./...passesgo test ./...passes./bin/hackernews ask --limit 3returns Ask HN stories./bin/hackernews show --limit 2returns Show HN stories./bin/hackernews jobs --limit 2returns HN job poststop,best,item,usercommands unaffected