feat(platform): inline file tools and apply public URL rewriting#891
Conversation
…L rewriting to storage queries Replace file agent delegation with direct file tool access (pdf, docx, pptx, text, image, excel) in the chat agent instructions and system defaults. Apply toPublicUrl() to all storage URL resolution in branding, files, and integrations queries so URLs are browser-reachable. Make toPublicUrl idempotent to prevent double-rewriting.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe PR refactors file handling by replacing agent delegation with direct use of built-in file tools. Chat agent instructions are updated to explicitly support Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
toPublicUrl()to storage queries: Ensure allctx.storage.getUrl()results in branding, files, and integrations queries are rewritten to browser-reachable URLs viatoPublicUrl().toPublicUrlidempotent: Prevent double-rewriting when a URL has already been transformed.Test plan
toPublicUrlis idempotent (calling it twice returns the same result)Summary by CodeRabbit
Release Notes
New Features
Improvements
Tests