refactor(automations): migrate workflow assistant to unified chat system

[larryro]

Summary

Migrates the workflow assistant from a dedicated agent implementation to the unified chat system, removing ~300 lines of bespoke code and aligning with the shared agent infrastructure.

Changes

Frontend (automation assistant)

• Replace dedicated chatWithWorkflowAssistant action with the shared chatWithAgent mutation
• Resolve workflow agent ID dynamically via new getSystemAgentBySlug query
• Add dual-layer loading state: optimistic (isPending) + server-reactive (isGenerating) with safety timeout
• Display file attachments in automation assistant messages using FileAttachmentDisplay
• Wrap handlers in useCallback for stable references

Backend (Convex)

• Add getSystemAgentBySlug query for slug-based agent resolution
• Pass additionalContext through the unified chat mutation
• Protect system agents (chat, workflow) from deletion and deactivation
• Enable filePreprocessingEnabled and publishOnSeed on the workflow agent template
• Use WORKFLOW_AGENT_CORE_INSTRUCTIONS instead of delegation-specific instructions

Removed

• convex/agents/workflow/actions.ts
• convex/agents/workflow/agent.ts
• convex/agents/workflow/generate_response.ts
• app/features/automations/hooks/actions.ts

Summary by CodeRabbit

• New Features

  • Added file attachment display support in automation assistant messages.
  • Implemented protection for system agents to prevent accidental deletion or deactivation.

• Improvements

  • Enhanced chat system with improved context and state management for better message handling and user experience.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR consolidates workflow-specific chat logic into a unified agent chat system. It removes the dedicated chatWithWorkflowAssistant action and workflow agent infrastructure, adds FileAttachment support for multimodal messaging throughout the chat pipeline, extends the unified agent chat API with an optional additionalContext parameter, introduces system agent protection for 'chat' and 'workflow' slugs, and refactors the automation assistant hook to use the generalized agent mutation with optimistic UI handling and file attachment management.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• feat(chat): display sub-agent model information in message info dialog #332: Both PRs modify unified_chat.ts to add an optional additionalContext parameter to the chatWithAgent function signature, indicating overlapping API changes.
• feat: UI improvements and automation enhancements #279: This PR modifies chatWithWorkflowAssistant with attachment and promptMessageId handling, while the main PR removes this action entirely, representing a direct architectural shift.
• improve coding agent #19: Both PRs implement the FileAttachment interface and add message attachments handling to the chat surface, with overlapping type definitions and UI rendering logic.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(automations): migrate workflow assistant to unified chat system' clearly summarizes the main change: migrating the workflow assistant from a dedicated implementation to the unified chat system, which aligns with the substantial changes removing ~300 lines of bespoke workflow code and integrating with shared infrastructure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/workflow-assistant-unified-chat

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}