perf(convex): deduplicate auth fetches in RLS helpers

[Israeltheminer]

Summary

• Fetches user and userOrganizations once in mutationWithRLS/queryWithRLS wrappers
• Passes pre-fetched data to rlsRules() via optional prefetchedData parameter
• Eliminates redundant getAuthenticatedUser() and getUserOrganizations() calls on every RLS-wrapped query/mutation

Test plan

• Verify existing RLS-protected queries/mutations still work correctly
• Confirm no duplicate auth fetches in Convex function logs

Summary by CodeRabbit

• Refactor
  • Optimized authentication data fetching by pre-fetching user and organization information once and reusing it across related operations, eliminating redundant database calls.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes refactor RLS (Row-Level Security) rule computation by modifying the call pattern in two helper files to pre-fetch authentication data once before invoking rlsRules. Instead of rlsRules fetching user and organization data internally, both mutation_with_rls.ts and query_with_rls.ts now retrieve this data upfront and pass it as an optional parameter to rlsRules. The rlsRules function signature is updated to accept optional pre-fetched data, with fallback logic to fetch data itself if not provided. This eliminates potential duplicate data fetches within rlsRules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'perf(convex): deduplicate auth fetches in RLS helpers' accurately and concisely describes the main optimization: eliminating duplicate authentication data fetches in RLS helper functions by prefetching once and passing the data as a parameter.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/rls-deduplicate-auth

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}