feat(cli): add download progress indicator to upgrade#1292
Conversation
Show real-time download progress (bytes/total/percentage) during `tale upgrade` so users can tell whether the download is progressing or stuck. Falls back gracefully in non-TTY environments.
Dev builds (version containing "dev") now always download the latest release. Removed the compiled-binary guard so local builds can test the full upgrade flow.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies the CLI self-upgrade implementation in a single file. It removes a guard that blocked upgrades based on the executable path, adds streaming-based binary download with progress indication (using TTY and color environment detection), introduces a helper function to format byte sizes, and adjusts the upgrade decision logic to treat development builds as requiring updates. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
tale upgradeso users can tell whether the download is progressing or stuckTest plan
cd tools/cli && bun run build:linuxdist/tale upgradeand verify progress indicator displays during downloadtale upgrade | catand verify no garbled output in non-TTY modetale upgradeon an up-to-date installation and verify it skips downloadSummary by CodeRabbit
Bug Fixes
New Features