Skip to content

feat(cli): add download progress indicator to upgrade#1292

Merged
larryro merged 2 commits into
mainfrom
feat/cli-download-progress
Apr 10, 2026
Merged

feat(cli): add download progress indicator to upgrade#1292
larryro merged 2 commits into
mainfrom
feat/cli-download-progress

Conversation

@larryro

@larryro larryro commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Show real-time download progress (bytes/total/percentage) during tale upgrade so users can tell whether the download is progressing or stuck
  • Remove dev mode guard so local builds can run the full upgrade flow
  • Dev builds (version containing "dev") always download the latest release

Test plan

  • Build CLI locally: cd tools/cli && bun run build:linux
  • Run dist/tale upgrade and verify progress indicator displays during download
  • Run tale upgrade | cat and verify no garbled output in non-TTY mode
  • Run tale upgrade on an up-to-date installation and verify it skips download

Summary by CodeRabbit

  • Bug Fixes

    • Resolved upgrade blocking issue affecting compiled binary installations, ensuring updates work seamlessly across all installation types.
    • Enhanced upgrade detection for development builds with improved version comparison logic.
  • New Features

    • Added interactive progress indicator displaying real-time download status during upgrades for better visibility.
    • Implemented efficient streaming support enabling faster and more stable package downloads.

larryro added 2 commits April 10, 2026 14:27
Show real-time download progress (bytes/total/percentage) during
`tale upgrade` so users can tell whether the download is progressing
or stuck. Falls back gracefully in non-TTY environments.
Dev builds (version containing "dev") now always download the latest
release. Removed the compiled-binary guard so local builds can test
the full upgrade flow.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@larryro larryro merged commit 728762d into main Apr 10, 2026
8 of 9 checks passed
@larryro larryro deleted the feat/cli-download-progress branch April 10, 2026 06:32
@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59b74e35-0409-4fd4-9d60-2be0cb48d837

📥 Commits

Reviewing files that changed from the base of the PR and between 0b79ba7 and 00d84af.

📒 Files selected for processing (1)
  • tools/cli/src/lib/actions/upgrade.ts

📝 Walkthrough

Walkthrough

This change modifies the CLI self-upgrade implementation in a single file. It removes a guard that blocked upgrades based on the executable path, adds streaming-based binary download with progress indication (using TTY and color environment detection), introduces a helper function to format byte sizes, and adjusts the upgrade decision logic to treat development builds as requiring updates.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: adding a download progress indicator to the upgrade feature, which aligns with the main implementation of streaming responses with progress tracking.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/cli-download-progress

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant