BridgeJS: Fix issues exporting nested types#783
Open
wfltaylor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are currently a few issues with the JS/TS code generation, due to a lack of merging. For example, the following Swift code:
generates a
.d.ts:This doesn’t type check correctly. Similar issues occur with the emitted
.js, except instead of failing to type check, these will cause runtime issues (since keys are overwritten instead of merged).This PR is a bit of a refactor of
BridgeJSLinkto address this. Instead of being a member of aNamespaceNode, each class and struct becomes its ownNamespaceNode. This makes it much easier to merge everything together so it can be emitted as one unit.