docs: add ERC-8004 interop documentation#2
Conversation
- Add ERC-8004 (Kuberna Labs) as a named section in competitive analysis with status, strengths, limitations, and AIP relationship details - Add ERC-8004 entry to Other Emerging Projects comparison table - Add erc8004 extension example to spec/aip-core.md identity document schema - Mention ERC-8004 in extensions field description and design decisions
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds documentation for ERC-8004 (Trustless Agents) to the competitive analysis guide. A new subsection describes the protocol's draft status, on-chain strengths, and limitations, then explains how it complements AIP through off-chain and on-chain layers. The document updates the emerging projects table and adds a reference link. ChangesERC-8004 Competitive Analysis
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/competitive-analysis.md`:
- Around line 128-143: Add a primary source link for ERC-8004 by inserting the
official EIP/spec/repo URL into the ## References section and then cite it
inline next to the "Status: Draft EIP, active development." line and the later
"ERC-8004" mention; specifically, update the text that includes "Status: Draft
EIP, active development." and the paragraph referencing "ERC-8004" to include a
parenthetical or bracketed citation pointing to the new References entry so the
deployment/status and claims are verifiable.
In `@spec/aip-core.md`:
- Around line 120-122: Add a small normative subsection that defines
extensions.erc8004: require an object with required keys "chain_id" (positive
integer) and "address" (string containing a 20-byte hex Ethereum-style address,
prefixed with 0x and validated as hex; optionally state checksum/case rules),
and allow an optional "metadata" object for freeform fields; specify types,
example JSON, and a short validation rule (e.g., JSON Schema fragment or
explicit bullet rules) and apply this definition wherever extensions.erc8004 is
referenced (the three occurrences) so producers/consumers can interoperate using
the functions/constructs named extensions.erc8004, chain_id, and address.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a4dcd6c-2b9f-4c9e-9058-b9d838214f9a
📒 Files selected for processing (2)
docs/competitive-analysis.mdspec/aip-core.md
|
Addressed both CodeRabbit review comments in commit 9ea8964:
|
sunilp
left a comment
There was a problem hiding this comment.
Thanks for following up from #1. The competitive-analysis content is useful and I want to land it, but two changes first.
-
Drop the
spec/aip-core.mdchanges. #1 scoped this to docs. A normative extension schema shouldn't land in the core spec before a working adapter exists to prove what the schema actually needs. Once your adapter runs against the spec we can revisit a non-normative example. -
Fix the attribution. ERC-8004 is an Ethereum ERC (Trustless Agents), not a Kuberna Labs project. Retitle the section "ERC-8004 (Trustless Agents)" and cite the EIP directly. Kuberna Labs can have one line as a third-party adapter in development. I'll add the link when it works against the spec, as agreed in #1.
Happy to merge the docs change with those two fixes.
|
The requested changes are addressed in commit c486604:
Ready for re-review. |
This PR adds documentation for the ERC-8004 (Kuberna Labs) interop with AIP, as discussed in issue #1.
Changes:
docs/competitive-analysis.md: New section for ERC-8004 with status, strengths, limitations, and AIP relationship describing how the two protocols complement each other (off-chain fast path via AIP, on-chain durable record via ERC-8004). Also adds ERC-8004 entry to the Other Emerging Projects comparison table.spec/aip-core.md: Addserc8004extension field example to the identity document JSON schema, updates the extensions field description, and adds ERC-8004 to the design decisions note.Interop pattern: An AIP identity document can include an
erc8004extension linking to an agent's on-chain registration, while an ERC-8004 delegation can reference an AIP token's scope as off-chain context. The adapter library consuming AIP as a primitive will live in the Kuberna Labs repos (separate PR).Summary by CodeRabbit
Release Notes