Making small change so that this can play nice with SQLiteCipher.swift - #389
Closed
gblotter wants to merge 3 commits into
Closed
Making small change so that this can play nice with SQLiteCipher.swift#389gblotter wants to merge 3 commits into
gblotter wants to merge 3 commits into
Conversation
updating from master
…sion can access it
Author
|
@stephencelis Any chance you've had a second to check out this PR? 😊 |
Owner
|
Not yet, sorry! Will try to find some time later today. |
Owner
|
@gblotter Do you have a link to your use in SQLiteCipher? |
Author
|
@stephencelis yeah, there is a a PR waiting for you in the repo w/ my use. |
|
Any chance of having this minor PR reviewed? Would be great to have SQLiteCipher sorted out. Thanks |
|
+1 |
|
bump |
jberkel
added a commit
that referenced
this pull request
Nov 16, 2016
Collaborator
|
This is now part of #531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to make
func check()be public, so that SQLiteCipher.swift can access it in it's extension of the Connection class.Please let me know what questions you have. if there is a better way of doing this, I'm open to suggestions. If you want to check out the details of the PR I have coming for the SQLiteCipher.swift repository, that uses this change, you can check it out here: https://github.com/gblotter/SQLite.swift/tree/SQLiteCipher-play-nice