Fix Chutes quota detail rendering - #2402
Conversation
|
The failed macOS shard is confined to untouched spend-dashboard tests, not the Chutes presentation path:
I attempted to rerun the failed jobs, but GitHub requires repository admin rights for this workflow. Could a maintainer rerun the failed CI jobs? Failed shard: https://github.com/steipete/CodexBar/actions/runs/29970896177/job/89092522895 @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Blocker update: I reproduced the shared macOS shard today, then applied only the isolated That confirms #2418 is the current root dependency; a separate fixture-clock patch was unnecessary and has been closed. Once #2418 lands, I will rebase this focused branch and rerun its targeted checks. No additional change to #2402 is warranted before then. |
|
Codex review: needs real behavior proof before merge. Reviewed July 28, 2026, 1:38 AM ET / 05:38 UTC. ClawSweeper reviewWhat this changesThis PR renders Chutes quota counts as usage detail rather than reset text in the menu card, native menu, and CLI, while retaining real reset timestamps and adding presentation regressions. Merge readiness⛔ Blocked until real behavior proof from a real setup is added - 3 items remain Keep this PR open for normal review. The supplied diff consistently treats Chutes quota strings as detail across the menu card, native menu, and CLI paths, and the added focused tests cover the reported combinations; however, the PR has not yet shown after-fix real behavior proof beyond automated tests. **Likely related people**
Priority: P2 Review scores
Verification
How this fits togetherCodexBar normalizes provider usage into quota windows, then projects those windows into the macOS menu bar, native menu descriptors, and command-line cards. Chutes puts quota-count text in a shared reset-description field, so each renderer must distinguish that detail from an actual reset schedule. flowchart LR
A[Chutes usage response] --> B[Usage window]
B --> C[Quota or reset classification]
C --> D[Menu card]
C --> E[Native menu]
C --> F[CLI card]
D --> G[Visible usage detail]
E --> G
F --> G
Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the narrow renderer classification after the contributor adds redacted runtime output proving that a Chutes quota count remains visible beside a real reset time and is not prefixed as a reset when no timestamp exists. Do we have a high-confidence way to reproduce the issue? Yes—source reproduction is high confidence: the linked report identifies existing Chutes fixtures that populate quota text in the reset-description field and deterministic renderer branches that previously classified it as reset content. Is this the best way to solve the issue? Yes—the branch follows the existing detail-backed-provider pattern rather than changing provider data contracts, and it applies that narrow classification at each affected presentation boundary. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against cd0bf3b3d6b0. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Verified the maintainer-refreshed head Verification on that tree:
Hosted lint, Linux, musl, and security checks are green; the two macOS shards are queued. The ClawSweeper request for a real menu screenshot and CLI transcript remains open. I did not run a live Chutes account probe; repository guidance calls for fixture/stub testing unless that probe is explicitly requested. |
|
Merged after full verification. Chutes quota counts now render as detail text in all three renderers (menu cards, native menus, CLI) while genuine reset timestamps are preserved. Exact-head CI: all nine checks green (https://github.com/steipete/CodexBar/actions/runs/30332082695 — the two macOS shards completed green after the earlier queue delay). Review + autoreview clean. Thanks @kiranmagic7! |
Fixes #2399.
Summary
Root cause
Chutes stores quota counts such as
40/100 requestsinRateWindow.resetDescription. The shared renderers either treated that field as reset text or dropped it whenresetsAtexisted.Verification
swift test --skip-build --no-parallel --filter 'Chutes(Provider|Presentation)Tests'— 14 tests passedmake check— passed (SwiftFormat: 0 files; SwiftLint: 0 violations)git diff --check— passedmake test— stopped on two unrelatedAdaptiveRefreshTimerTeststimeouts; both failures reproduce unchanged on base commitcc8da27cCompatibility risk: low. This only changes presentation for Chutes quota windows; real reset timestamps remain rendered separately.
Review focus: please sanity-check the detail-backed provider handling across the three renderers.