feat(test-infra): adopt Jest 30.4.x – ts-node, workerGracefulExitTimeout & test:list

[steilerDev]

Summary

Closes #1573

Adopts the runner enhancements introduced by the jest 30.3.0 → 30.4.2 bump (see PR #1511) by applying the two concrete opportunities identified in the issue.

Changes

package.json

Package	Before	After
jest	30.3.0	30.4.2
jest-environment-jsdom	30.3.0	30.4.1
ts-node	(not present)	10.9.2 (new)

• Added test:list script: node --experimental-vm-modules node_modules/.bin/jest --collect-tests

jest.config.ts

Added workerGracefulExitTimeout: 5000 at the top-level config object. This gives Jest workers 5 seconds to exit cleanly before force-killing them, reducing intermittent hangs in sandbox CI environments caused by file-watcher cleanup stalls (the existing 'environment torn down' ReferenceErrors are a symptom of exactly this race condition).

Why ts-node?

Jest 30.x introduced a new TypeScript config-loader mechanism. When jest.config.ts is used, jest-config now explicitly requires a TS loader (ts-node by default, or esbuild-register). Adding ts-node as an explicit devDependency makes this requirement visible and reproducible across all environments (previously it may have been satisfied by a transitive dependency in the lockfile).

Sanity Check

$ npm run test:list
> node --experimental-vm-modules node_modules/.bin/jest --collect-tests
# exits 0, lists test files without executing them

Not included (follow-up)

A List tests CI step (running npm run test:list before shard steps as a discovery sanity gate) requires workflow scope in the GitHub token. This should be added directly in the repo or as a separate PR with appropriate credentials.

[steilerDev]

[product-owner]

Product Owner Review — PR #1620

Reviewed against Issue #1573 acceptance criteria. All three criteria are met.

---

AC Verification

#	Acceptance Criterion	Status	Evidence
AC1	jest + jest-environment-jsdom bumped to 30.4.x	✅ PASS	jest: 30.3.0 → 30.4.2 · jest-environment-jsdom: 30.3.0 → 30.4.1 (both 30.4.x)
AC2	workerGracefulExitTimeout: 5000 added to jest.config.ts	✅ PASS	Confirmed in jest.config.ts diff — added at top-level config with explanatory comment
AC3	test:list script added using --collect-tests flag	✅ PASS	"test:list": "node --experimental-vm-modules node_modules/.bin/jest --collect-tests" added to package.json

---

Additional Delivery: ts-node 10.9.2

The addition of ts-node as an explicit devDependency is a well-reasoned improvement: Jest 30.x requires an explicit TS loader for jest.config.ts. Making it a visible, pinned devDependency prevents silent breakage if a transitive dependency that previously satisfied this requirement is ever removed. This is correct and appropriate scope for the issue.

---

Deferred: CI 'List tests' step

The PR description correctly flags that adding a List tests CI workflow step requires workflow scope beyond the current token permissions. This item was not part of Issue #1573's acceptance criteria, so its deferral is acceptable. A follow-up issue should be filed to track the CI gate addition.

---

Verdict: ✅ APPROVED — All AC met. Ready to merge.

All acceptance criteria from Issue #1573 are satisfied. The Closes #1573 trailer is present and correct. The PR is clear on scope, rationale, and what was intentionally deferred.

---

Co-Authored-By: Claude product-owner (Opus 4.6) noreply@anthropic.com

[steilerDev]

[product-architect]

PR Review: feat/1573-jest-collect-tests-worker-timeout → main

Verdict: ✅ Approved — all changes are architecturally sound, consistent with project conventions, and confined to dev tooling. Findings below are informational only.

---

1. ts-node vs esbuild-register — correct choice ✅

ts-node 10.9.2 (latest stable; 11.0 is still in beta) is the right pick for this project. The CLAUDE.md dependency policy explicitly states that esbuild has been fully eliminated due to native binary crashes on ARM64 emulation. esbuild-register is a thin wrapper that peers against esbuild itself, meaning it would reintroduce that exact violation. ts-node is pure JavaScript — its optional @swc/core/@swc/wasm peer dependencies are not installed (confirmed: no node_modules/@swc entries appear in the PR diff). This is consistent with ADR-005's rationale of choosing ts-jest (pure JS transform) over esbuild-based alternatives.

Importantly, ts-node was already an optional peer dependency of jest-config back in 30.3.0 — the requirement did not change in 30.4.x. What changed is that projects relying on jest.config.ts more routinely need it materialised (30.4 introduced jest.config.mts support and tightened the TS config-loader path). Explicit pinning avoids any "missing optional peer" warning surfacing in CI.

2. workerGracefulExitTimeout: 5000 — reasonable value ✅

The Jest default is 500 ms (confirmed via jest-config Defaults.ts source). The PR raises this to 5 000 ms (10×). The comment accurately explains the rationale: sandbox/CI environments where file-watcher cleanup (fb-watchman / fsevents) stalls can cause worker exit to miss the 500 ms window and trigger a spurious SIGKILL + diagnostic noise. A 5-second grace period is well within the safety margin for a test suite running in 6 CI shards — it only fires on abnormal shutdown paths and has no effect on passing-test latency. This is placed at the correct top-level scope of the config (not inside a project entry), so it applies globally.

3. Production dependencies — unaffected ✅

All three changed packages (jest, jest-environment-jsdom, ts-node) carry "dev": true in the lockfile. No production-runtime dependency was modified. The lockfile change also reflects npm normalising away some redundant "license" fields from indirect devDependencies — this is cosmetic behaviour of npm 10.x and does not signal any functional change.

4. Lockfile consistency ✅

The PR lockfile correctly:

• Replaces jest 30.3.0 → 30.4.2 and jest-environment-jsdom 30.3.0 → 30.4.1 in the root node_modules entries.
• Adds the full ts-node 10.9.2 subtree (including its @cspotcode/source-map-support transitive dependency with a pinned @jridgewell/trace-mapping 0.3.9).
• Bumps the cascading @jest/* family (console, core, environment, reporters, runner, runtime, etc.) to their 30.4.x equivalents.
• The ical-generator diff is a cosmetic re-serialisation of an unchanged record (integrity hash is identical); no functional change.

package.json pins ts-node to an exact version (10.9.2) in line with project policy.

5. test:list script ✅

node --experimental-vm-modules node_modules/.bin/jest --collect-tests is the correct invocation pattern — it mirrors all existing test:* scripts and uses the same ESM launcher. --collect-tests was introduced in Jest 30.4.0 (confirmed in the official changelog, PR #16006), so the version bump is a prerequisite for this script.

6. Deferred CI workflow step — acceptable with follow-up ⚠️

The PR description acknowledges that the .github/workflows/ci.yml "List tests" step was deferred due to auth-proxy workflow-scope constraints. This is acceptable as a short-term gap — the test:list script works standalone and the CI matrix is unaffected by its absence. However, the step should be added in a follow-up once the auth-proxy constraint is lifted, so that test discovery regressions surface in CI automatically.

Recommendation: open a follow-up issue (or add a TODO(ci): comment in ci.yml) to track the missing "List tests" step before this reaches a release tag.

---

Summary

Area	Finding	Severity
ts-node choice	Correct — esbuild-register would violate native binary policy	✅ Pass
workerGracefulExitTimeout value	5000 ms appropriate (10× default, no latency impact on happy path)	✅ Pass
Production deps	No production dependencies affected	✅ Pass
Lockfile consistency	Consistent with package.json; cosmetic normalisation only	✅ Pass
test:list script	Correct invocation, prerequisite version satisfied	✅ Pass
CI workflow step	Deferred — acceptable short-term, warrants a tracked follow-up	ℹ️ Info

No blocking or critical findings.

[steilerDev]

Closing as deferred — not abandoned. Two reasons:

1. workerGracefulExitTimeout: 5000 was originally added as defensive hardening against worker-exit hangs that we attributed to E2E Cache Warmup timeouts. Root-cause analysis of those CI hangs (2026-05-30) determined they were Playwright CDN flakes, not Jest worker leakage. The marginal value of workerGracefulExitTimeout here is now small.
2. The lockfile regeneration this PR requires (adding ts-node as an explicit devDep) introduced a Konva 9.x vs 10.x type collision between root and client workspaces — Type 'RefObject<Stage | null>' is not assignable to type 'Ref<Stage> | undefined'... Property 'miterLimit' is missing. Resolving the collision requires a deeper deps audit than is justified for the remaining value.

Re-opens via the follow-up issue below when:

• We do a wider workspace dependency audit, OR
• npm run test:list is needed for CI test discovery (would re-justify the ts-node addition).

Tracker: #1573 stays open, repurposed to track the deferred --collect-tests adoption.