Open
Conversation
… most of the content I want to express but could use a fair amount polish
…than linq and added full outer join example
This reverts commit 7d495b5.
Collaborator
There was a problem hiding this comment.
One difference between this and C#'s Task.WhenAll() is that it looks like the promise returned by allSettled will be fulfilled regardless of whether the underlying promises are fulfilled or rejected. The .NET API marks the wrapper task as faulted if any of the underlying tasks are faulted.
I'm not saying you should change the implementatin, but it's probably worth calling this out and why you like the behavior as is.
Owner
Author
There was a problem hiding this comment.
$q.all is provided by default and does exactly what you describe. I use $q.all a lot and think it's more useful than $q.allSettled. But I'll call out the differences between $q.all and $q.allSettled.
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.