Skip to content

Use jumbo tests in prim#1965

Merged
rok-cesnovar merged 5 commits intodevelopfrom
faeture/1948_use_jumbo_prim
Aug 2, 2020
Merged

Use jumbo tests in prim#1965
rok-cesnovar merged 5 commits intodevelopfrom
faeture/1948_use_jumbo_prim

Conversation

@rok-cesnovar
Copy link
Member

@rok-cesnovar rok-cesnovar commented Jul 6, 2020

Summary

Advances #1948 by using jumbo test for /prim. See the issue for more details on what jumbo tests are.

This is not a priority so feel free to ignore this until the release.

Tests

This is only touching tests.

Side Effects

/

Checklist

  • Math issue Use jumbo tests #1948

  • Copyright holder: Rok Češnovar, Univ. of Ljubljana

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jul 9, 2020

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.04 4.08 0.99 -0.99% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -1.3% slower
eight_schools/eight_schools.stan 0.09 0.09 0.97 -3.06% slower
gp_regr/gp_regr.stan 0.19 0.19 0.99 -0.92% slower
irt_2pl/irt_2pl.stan 5.38 5.4 1.0 -0.37% slower
performance.compilation 86.17 85.34 1.01 0.96% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.73 7.72 1.0 0.13% faster
pkpd/one_comp_mm_elim_abs.stan 21.46 21.78 0.99 -1.47% slower
sir/sir.stan 93.72 95.33 0.98 -1.72% slower
gp_regr/gen_gp_data.stan 0.05 0.05 0.98 -2.2% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.01 3.1 0.97 -2.95% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.33 0.35 0.94 -6.69% slower
arK/arK.stan 1.79 1.76 1.01 1.45% faster
arma/arma.stan 0.72 0.73 0.99 -1.1% slower
garch/garch.stan 0.52 0.52 1.01 0.68% faster
Mean result: 0.987478294093

Jenkins Console Log
Blue Ocean
Commit hash: 20b2d6f

Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jul 10, 2020

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.05 4.01 1.01 0.98% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.03 2.96% faster
eight_schools/eight_schools.stan 0.09 0.09 1.04 3.71% faster
gp_regr/gp_regr.stan 0.19 0.19 1.03 2.66% faster
irt_2pl/irt_2pl.stan 5.37 5.36 1.0 0.13% faster
performance.compilation 86.27 84.99 1.02 1.49% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.74 7.72 1.0 0.21% faster
pkpd/one_comp_mm_elim_abs.stan 21.06 21.05 1.0 0.05% faster
sir/sir.stan 94.14 101.24 0.93 -7.54% slower
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 -0.42% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.01 3.01 1.0 0.03% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.33 0.34 0.97 -3.56% slower
arK/arK.stan 1.78 1.79 1.0 -0.44% slower
arma/arma.stan 0.72 0.73 1.0 -0.13% slower
garch/garch.stan 0.52 0.52 0.99 -0.61% slower
Mean result: 1.00034994786

Jenkins Console Log
Blue Ocean
Commit hash: 20b2d6f

Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jul 10, 2020

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.01 4.05 0.99 -0.78% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 -0.44% slower
eight_schools/eight_schools.stan 0.09 0.09 1.0 -0.46% slower
gp_regr/gp_regr.stan 0.19 0.19 0.98 -2.08% slower
irt_2pl/irt_2pl.stan 5.36 5.38 1.0 -0.42% slower
performance.compilation 87.62 85.26 1.03 2.69% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.92 7.72 1.03 2.57% faster
pkpd/one_comp_mm_elim_abs.stan 20.71 21.37 0.97 -3.16% slower
sir/sir.stan 95.84 95.58 1.0 0.27% faster
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 0.0% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.01 3.02 1.0 -0.22% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.33 0.34 0.97 -3.46% slower
arK/arK.stan 1.78 1.78 1.0 -0.38% slower
arma/arma.stan 0.72 0.71 1.02 2.08% faster
garch/garch.stan 0.51 0.52 0.99 -0.55% slower
Mean result: 0.997423639335

Jenkins Console Log
Blue Ocean
Commit hash: 20b2d6f

Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jul 13, 2020

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.96 4.0 0.99 -1.11% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -1.35% slower
eight_schools/eight_schools.stan 0.09 0.09 1.04 3.77% faster
gp_regr/gp_regr.stan 0.2 0.19 1.05 4.62% faster
irt_2pl/irt_2pl.stan 5.36 5.33 1.01 0.58% faster
performance.compilation 87.46 84.8 1.03 3.04% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.83 7.83 1.0 0.03% faster
pkpd/one_comp_mm_elim_abs.stan 20.87 20.38 1.02 2.31% faster
sir/sir.stan 92.15 92.33 1.0 -0.19% slower
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 0.43% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.04 3.05 1.0 -0.33% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.32 0.34 0.96 -4.46% slower
arK/arK.stan 1.79 1.77 1.01 1.14% faster
arma/arma.stan 0.72 0.71 1.01 1.18% faster
garch/garch.stan 0.51 0.51 1.0 -0.14% slower
Mean result: 1.00686994892

Jenkins Console Log
Blue Ocean
Commit hash: 20b2d6f

Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

syclik
syclik approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rok-cesnovar rok-cesnovar merged commit 0e80ba3 into develop Aug 2, 2020
rok-cesnovar added a commit that referenced this pull request Aug 2, 2020
@rok-cesnovar
fix develop issues after merging #1965
5b4d4c1
@rok-cesnovar rok-cesnovar mentioned this pull request Aug 2, 2020
Merged
5 tasks
@bbbales2 bbbales2 mentioned this pull request Aug 10, 2020
Closed
5 tasks
bbbales2 added a commit that referenced this pull request Aug 26, 2020
@bbbales2
Moved around the ODE functors. They're an alternative fix for a probl…
83c27cd 
…em that popped up with #1965
@rok-cesnovar rok-cesnovar deleted the faeture/1948_use_jumbo_prim branch November 28, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syclik syclik syclik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rok-cesnovar @stan-buildbot @syclik