feat(golang): implement multi-version support#237
Open
rubenhoenle wants to merge 4 commits intomainfrom
Open
Conversation
relates to STACKITSDK-294 and STACKITSDK-297
rubenhoenle
force-pushed
the
multi-version
branch
from
2d567f6 to
f76d02e
Compare
rubenhoenle
commented
Feb 27, 2026
| # Generate SDK for each service | ||
| for service_json in ${ROOT_DIR}/oas/legacy/*.json; do | ||
| service="${service_json##*/}" | ||
| for service_dir in "${ROOT_DIR}/oas/services"/*; do |
Contributor
There was a problem hiding this comment.
should we still filter for .json extension?
Member
Author
There was a problem hiding this comment.
This for statement is to overate over all the service directories (iaas, postgresflex, ...).
Could you elaborate why/how we should filter for .json extensions here? 😅
Contributor
|
general comment regarding deprecation: could we have deprecated the whole package instead? |
Member
Author
If I got it correctly you can deprecate a whole package in Golang by doing this // Deprecated
package foobarSee https://go.dev/wiki/Deprecated for reference. Edit: I marked everything in the compatibility layer deprecated (additionally to the package deprecation) to make it more explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to STACKITSDK-294 and STACKITSDK-297