Skip to content

add hack to not retry creation for machines that errored with "No valid host was found" #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kumm-Kai merged 1 commit into from
Mar 7, 2025
Merged

add hack to not retry creation for machines that errored with "No valid host was found" #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/util/provider/machinecontroller/machine_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,10 @@ func (c *controller) machineCreateErrorHandler(ctx context.Context, machine *v1a
switch machineErr.Code() {
case codes.Unknown, codes.DeadlineExceeded, codes.Aborted, codes.Unavailable:
retryRequired = machineutils.ShortRetry
// HACK: machines that are in error state because of ResourceExhaused ("No valid host was found" error) should not be retries within the lifecycle of the machine object.
// Our effectiveCreationTimeout is 20m, so the machine will be deleted after the 30m.
case codes.ResourceExhausted:
retryRequired = machineutils.RetryPeriod(30 * time.Minute)
}
}

Expand Down