Skip to content

docs: pod overrides, better install instructions, improved wording#569

Merged
razvan merged 6 commits intomainfrom
docs-improvements
Sep 27, 2024
Merged

docs: pod overrides, better install instructions, improved wording#569
razvan merged 6 commits intomainfrom
docs-improvements

Conversation

@fhennig
Copy link
Copy Markdown
Contributor

@fhennig fhennig commented Sep 24, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@fhennig fhennig self-assigned this Sep 24, 2024
@fhennig fhennig mentioned this pull request Sep 24, 2024
Closed
@razvan razvan self-requested a review September 27, 2024 10:15
razvan
razvan reviewed Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions

@razvan razvan enabled auto-merge September 27, 2024 10:37
razvan
razvan approved these changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@razvan razvan added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 684ab56 Sep 27, 2024
@razvan razvan deleted the docs-improvements branch September 27, 2024 10:55
razvan added a commit that referenced this pull request Sep 30, 2024
@fhennig @razvan
docs: pod overrides, better install instructions, improved wording (#569
2d2d564 
)

* ~

* Update docs/modules/hbase/pages/getting_started/installation.adoc

* Update docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc

* Update docs/modules/hbase/pages/usage-guide/operations/pod-placement.adoc

* Update docs/modules/hbase/pages/usage-guide/security.adoc

* fix: spelling

---------

Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

Assignees

@fhennig fhennig

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fhennig @razvan