Skip to content

Support user authentication using Kerberos#436

Merged
sbernauer merged 37 commits intomainfrom
feat/kerberos-reloaded
Jan 19, 2024
Merged

Support user authentication using Kerberos#436
sbernauer merged 37 commits intomainfrom
feat/kerberos-reloaded

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Jan 9, 2024

Description

Closes #285

Missing

  • docs
  • tests for accessing restserver
  • docs on discovery

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved => Copy/pasted from hdfs
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

@sbernauer sbernauer changed the title WIP: Kerberos support Allow enabling user authentication with Kerberos Jan 10, 2024
@sbernauer sbernauer marked this pull request as ready for review January 15, 2024 12:22
@sbernauer
Copy link
Copy Markdown
Member Author

It would be great if someone could review the actual code, docs will follow

@sbernauer sbernauer self-assigned this Jan 15, 2024
@sbernauer sbernauer changed the title Allow enabling user authentication with Kerberos Support user authentication using Kerberos Jan 16, 2024
@maltesander maltesander self-requested a review January 16, 2024 16:41
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch, will continue and test tomorrow!

sbernauer and others added 8 commits January 17, 2024 08:55
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer sbernauer requested a review from maltesander January 17, 2024 13:10
@sbernauer
Copy link
Copy Markdown
Member Author

@sbernauer sbernauer force-pushed the feat/kerberos-reloaded branch from 84a5ff7 to befba73 Compare January 18, 2024 08:59
@sbernauer sbernauer requested a review from maltesander January 18, 2024 09:03
@sbernauer
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Copy Markdown
Member Author

Many thanks for the quick review!

@sbernauer sbernauer added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 55f6317 Jan 19, 2024
@sbernauer sbernauer deleted the feat/kerberos-reloaded branch January 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow enabling user authentication with Kerberos

3 participants