ADR 29: Standardize database connections#321
Merged
Conversation
sbernauer
reviewed
Dec 6, 2022
Member
There was a problem hiding this comment.
Quick pass, just doing minor writing stuff.
Some questions, just writing them down, would suggest to have a call about them:
- Is
DatabaseConnectionnamespaced? Would be fine for me. If not we would have to use aSecretClassas Secrets are namespaced - What do you think of a complex enum within
DatabaseConnection? - I personally don't like putting something like
driverpr protocol into the global CRD. That seems like a implementation detail of the individual product to me
Just throwing in an idea that should address the above points
apiVersion: databaseconnection.stackable.tech/v1alpha1
kind: DatabaseConnection
metadata:
name: druid-metadata-connection
namespace: default
spec:
database:
postgresql:
host: druid-postgresql # mandatory
port: 5432 # defaults to some port number - depending on wether tls is enabled
schema: druid # defaults to druid
credentials: druid-postgresql-credentials # mandatory. key username and password
parameters: "" # optional
redis:
host: airflow-redis-master # mandatory
port: 6379 # defaults to some port number - depending on wether tls is enabled
schema: druid # defaults to druid
credentials: airflow-redis-credentials # optional. key password. In case redis also supports usernames key username and password
parameters: "" # optional
derby:
location: /tmp/derby/ # optional, defaults to /tmp/derby-{metadata.name}/derby.db
parameters: "create=true" # optional
When we add tls support, things get more tricky
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
19 tasks
sbernauer
reviewed
May 26, 2023
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
48f33a8 to
fd414be
Compare
sbernauer
approved these changes
Aug 22, 2023
Techassi
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by stackabletech/hive-operator#148
Fixes stackabletech/issues#238