Make uid/gid configurable & change group of files - part 2#890
Merged
Make uid/gid configurable & change group of files - part 2#890
Conversation
This is a follow-up for #849 and includes: - The missing bits for Hive - Kafka
6 tasks
- Kafka Testing Tools - KCat - NiFi - Omid
26 tasks
lfrancke
changed the title
NickLarsenNZ
previously approved these changes
Oct 16, 2024
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
LGTM, I assume the images build locally.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Member
Author
|
And to answer your question: Yes, it builds locally and I did run all tests (see the issue description) and it all looks good. |
Techassi
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Make uid/gid configurable & change group of files This is a follow-up for #849 and includes: - The missing bits for Hive - Kafka * More tools now migrated but not tested yet: - Kafka Testing Tools - KCat - NiFi - Omid * - OPA - Spark (WIP) * Adds Spark and a changelog entry * Update CHANGELOG.md Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> * Update comment --------- Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make uid/gid configurable & change group of files.
This is a follow-up for #849 (please check there for details).
This includes ( ✔️ means all tests have been run)
There are still a few tools missing and they'll come in a follow-up PR
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.