Merged
Conversation
It'd warn about GIT_SYNC being possibly undefined. This is correct in theory, in practice however we always set it from the outside and defining it here could lead to version skew or another place to update versions.
NickLarsenNZ
reviewed
Oct 4, 2024
Member
There was a problem hiding this comment.
Relates to #849 (review)
I think we should set defaults in Dockerfiles. We just happen to set them in bake, but IMO we shouldn't assume bake is used for Dockerfiles (yes, I know many of our builds depend on layers having already been built locally, but decoupling where we can would be nice).
NickLarsenNZ
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It'd warn about GIT_SYNC being possibly undefined. This is correct in theory, in practice however we always set it from the outside and defining it here could lead to version skew or another place to update versions.