HDFS: Allow overriding datanode registration addresses#506
Merged
Conversation
nightkr
commented
Nov 16, 2023
6adc69e to
47454e9
Compare
Contributor
Author
|
The 3.3.4 variant is tested against stackabletech/hdfs-operator@2cd93ad. The 3.3.6 variant is untested due to stackabletech/hdfs-operator#440. There is no 3.2.x backport, on the hypothesis that any new clusters should be running 3.3.x+, and any existing clusters have clearly already been fine without external access.. :P stackabletech/hdfs-operator#450 should not break in-cluster access to HDFSes without this patch applied (they would silently ignore the override, falling back to the cluster-internal address). |
siegfriedweber
previously approved these changes
Jan 11, 2024
Member
siegfriedweber
left a comment
There was a problem hiding this comment.
LGTM
You could add this to the changelog.
Contributor
Author
|
Good catch, will do. |
Contributor
Author
siegfriedweber
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/hdfs-operator#174, implemented by rebuilding HDFS from source, after applying the required patches.
Definition of Done Checklist