fix(trino): Reactivate the commitid plugin, otherwise tests fail#1160
Merged
NickLarsenNZ merged 1 commit intomainfrom Jun 11, 2025
Merged
fix(trino): Reactivate the commitid plugin, otherwise tests fail#1160NickLarsenNZ merged 1 commit intomainfrom
NickLarsenNZ merged 1 commit intomainfrom
Conversation
lfrancke
approved these changes
Jun 11, 2025
Member
lfrancke
left a comment
There was a problem hiding this comment.
In the future we can just patch the POM I guess
Member
Author
|
14 tasks
Member
|
Thanks past me to add a test for this to the smoke tests :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1082.
Fixes tests that require the version in SQL queries (and likely the version being displayed in the web UI).
Reverts back to what @sbernauer had done in #881