fix(nifi): Conditionally disable Host Port Validation in NiFi 2.4.0#1125
Merged
fix(nifi): Conditionally disable Host Port Validation in NiFi 2.4.0#1125
Conversation
Member
|
Test build triggered: https://github.com/stackabletech/docker-images/actions/runs/15187818491 |
Member
Author
|
During local testing I was able to access the NiFi UI without the HTTP 421 error. |
15 tasks
Member
|
Is this something we should mention in the release notes? |
Member
Author
Yes, this is relevant to security so it should be mentioned. I've added a release note snippet to the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting in NiFi 2.4.0 the host header validation has been replaced by host port validation: apache/nifi#9680
This adds a patch that replaces
0002-Allow-bypassing-check-for-host-header.patchwhich was used to turn host header validation off if the list of allowed hosts contained only*.Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.Release Notes
NiFi: Update patch that allows bypassing the host header validation starting with NiFi 2.4.0