Conversation
19 tasks
maltesander
requested changes
May 28, 2025
Member
maltesander
left a comment
There was a problem hiding this comment.
First batch, will do some more testing.
tests/templates/kuttl/external-access/install-airflow-cluster.yaml.j2
Outdated
Show resolved
Hide resolved
12 tasks
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
NickLarsenNZ
previously requested changes
Jun 2, 2025
Member
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Sorry if I missed it, but it looks like the supported-version.adoc is missing the 3.0.1 (experimental) addition
Member
Author
No, you were correct - thanks! 9dfe57e |
maltesander
reviewed
Jun 2, 2025
maltesander
previously approved these changes
Jun 2, 2025
Member
maltesander
left a comment
There was a problem hiding this comment.
LGTM if tests (OS) pass :)
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #618
Most changes in this PR are due to the fact that the API has changed and both old and new versions need to be available for the tests. Code changes can be summarised as:
N.B. this PR does not cover updates to OPA-Auth (covered separately).
Definition of Done Checklist
Author
CRD changes approvedCRD documentation for all fields, following the [style guide]Reviewer
Acceptance